Skip to content

Add private folder to template #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Add private folder to template #888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions default-templates/new-account/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ <h1>Data</h1>
<span class="lead">Public Folder</span>
<span class="badge">public</span>
</a>
<a href="/private/" target="_blank" class="list-group-item">
Copy link
Contributor

@megoth megoth Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary with target="_blank"? It's usually an annoyance for most use cases.

Copy link
Contributor

@megoth megoth Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a "Good reason" (ref https://css-tricks.com/use-target_blank/) for doing this, but maybe there's something I'm missing?

Copy link
Contributor Author

@RubenVerborgh RubenVerborgh Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy/paste from what was above.

But a good reason would be that the click brings them to Databrowser, which might be very overwhelming at first. They can just close and be back on the homepage.

Copy link
Contributor

@megoth megoth Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's continue that practice for now then

<span class="lead">Private Folder</span>
<span class="badge">private</span>
</a>
</div>
</section>

Expand Down
10 changes: 10 additions & 0 deletions default-templates/new-account/private/.acl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# ACL resource for the private folder
@prefix acl: <http://www.w3.org/ns/auth/acl#>.

# The owner has all permissions
<#owner>
a acl:Authorization;
acl:agent <{{webId}}>;
acl:accessTo <./>;
acl:defaultForNew <./>;
acl:mode acl:Read, acl:Write, acl:Control.