Feature/mba 39 - #112
Merged
Merged
Conversation
fake _Query의 apply_paging 플래그를 제거하고 all()이 항상 offset/limit을 slicing하도록 수정. page=2 요청 시 첫 페이지 결과가 반환되지 않음을 검증. 이슈 #53 해결 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- 공통 요청 모듈에 함수를 만들었습니다.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
#111 PR이 main으로 요청되어있었습니다. 이에,
dev를 base로 재시도합니다.Merge pull request #111 from nodease/feature/mba-39
test(audit): pagination 테스트가 실제 offset/limit을 검증하도록 보완
P1 Badge Send the active organization on app requests
./apps/client/lib/activeOrganization.ts에axios request interceptor헬퍼를 만들고,./apps/client/lib/apiClient.ts에apiFetch도 추가함.이제 저장된
moduly_active_organization_id가 있으면axios요청과apiFetch요청에 자동으로X-Organization-Id가 붙는다.적용한 곳:
appApi,workflowApi,webhookApi의axios인스턴스기존
apiClient/api/v1로 직접 fetch하던 workflow/LLM wizard/sidebar 호출들
직접 axios.post하던 knowledge search 컴포넌트는 apiClient로 변경
검증:
주의할 점은 앞으로 새 API 호출을 만들 때 axios는 apiClient를 쓰고, fetch가 필요하면 apiFetch를 쓰면 같은 정책이 자동 적용.
P2 Allow marketplace apps to be cloned publicly
apps/gateway/services/app_service.py(line 137)의can_read_app()맨 앞에:is_market == True라면 clone할 수 있습니다.관련 이슈
변경 유형
테스트
스크린샷 (UI 변경 시)