Skip to content

Windows fixes #21

Closed
stammen wants to merge 4 commits intonodejitsu:masterfrom
MSOpenTech:windows-fix
Closed

Windows fixes #21
stammen wants to merge 4 commits intonodejitsu:masterfrom
MSOpenTech:windows-fix

Conversation

@stammen
Copy link
Contributor

@stammen stammen commented Dec 3, 2012

This branch contains the few changes needed to make nodejitsu-api run on windows. The following changes were required:

  1. updated vows dependency to ver 0.7.x so npm tests will run on windows.
  2. updated nock tests to use os.EOL instead of \n when checking request body. Tests will fail in nock if body contains \r\n when fixture file is read on windows.
  3. Added a .gitignore file to the root directory of the project. Added ./idea to .gitignore to ignore Webstorm IDE files.

All npm tests pass on windows.

@mmalecki
Copy link
Contributor

mmalecki commented Dec 6, 2012

That's awesome, thanks Dale. I pulled your first three commits (cherry-picked).
As to \n, I solved this in 3bb1ac2, disabling automatic conversion which git does. I think that this is the better solution here since, say, text editors can use \n even on Windows. Would you mind recloning the repo and letting me know if it works?

@stammen
Copy link
Contributor Author

stammen commented Dec 6, 2012

Just tested on mac/windows/linux. All 28 tests passed on all platforms. Thanks for .gitattributes fix.

@indexzero
Copy link
Member

@mmalecki Since you cherry-picked the relevant stuff can this be closed?

@mmalecki
Copy link
Contributor

Dang. Forgot to close.

@mmalecki mmalecki closed this Dec 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants