jenkins: node-test-commit-linux-containered should set IDENTIFIER=node-test-commit-linux-containered ?

[joyeecheung]

See https://ci.nodejs.org/job/node-test-commit-linux-containered/configure The parameters passed to post-build-status-update currently set IDENTIFIER=${STATUS_LABEL} which appear in the Github PR status as ${STATUS_LABEL}. I believe it's supposed to be IDENTIFIER=node-test-commit-linux-containered instead?

[maclover7]

There's also this part of the build configuration, which I believe is trying to customize the github-bot status label?

echo $nodes | sed -E 's/.*_(\w+)_x64$/STATUS_LABEL=node-test-linux-linked-\1/g' > env.properties

cc @rvagg

[refack]

Moving the aforementioned line to the top of the script should minimize such errors:
https://ci.nodejs.org/job/node-test-commit-linux-containered/jobConfigHistory/showDiffFiles?timestamp1=2018-08-16_18-01-41&timestamp2=2018-08-16_18-07-22

[refack]

Nope - https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1604_sharedlibs_openssl110_x64/6352/console
Seems like on test-softlayer-ubuntu1604_sharedlibs_container-x64-5 the following replace fails:

20:54:20 + echo ubuntu1604_sharedlibs_openssl110_x64
20:54:20 + sed -E s/.*_(\w+)_x64$/STATUS_LABEL=node-test-linux-linked-\1/g
20:54:20 + echo

[github-actions]

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.