chore: consume dist/index.json when resolving versions - #2598
Conversation
MikeMcC399
left a comment
There was a problem hiding this comment.
I ran it against a branch with the latest Node.js 26.7.0 removed, and ./update.sh 26 added it correctly.
nschonni
left a comment
There was a problem hiding this comment.
Did a quick test with curl -sSL --compressed "https://nodejs.org/dist/index.json" | jq -r '[.[] | select(.version | startswith("v24."))] | first | .version | ltrimstr("v")'.
Did something similar with the JS rewrite branches
|
I don't have write access here, so will leave this with y'all to land 🙏 |
|
I tested it also in my fork, both on the current state and rewinding to Node.js 26.6.0 and it worked fine. Thank you for your support @MattIPv4 👍🏻 |
|
I've added two PRs due to This isn't an issue in GitHub runners. It just needs an additional step for contributors if they don't already have The error message without $ ./update.sh
Updating version 22...
Updating version 24...
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
Updating version 26...
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
./update.sh: line 118: jq: command not found
curl: (23) Failure writing output to destination
curl: (23) Failure writing output to destination
curl: (23) Failure writing output to destination
curl: (23) Failure writing output to destination
curl: (23) Failure writing output to destination
curl: (23) Failure writing output to destination
curl: (23) Failure writing output to destination
curl: (23) Failure writing output to destination
curl: (23) Failure writing output to destination
curl: (23) Failure writing output to destination
curl: (23) Failure writing output to destination
curl: (23) Failure writing output to destination
curl: (23) Failcuurrel :w r(i2t3i)n gF aoiultupruet wtroi tdiensgt ionuattpiuotn
to destination
curl: (23) Failure writing output to destination
curl: (23) Failure writing output to destination
curl: (23) Failure writing outpcuutr lt:o destination
(23) Failure writing output to destination
curl: (23) Failure writing output to destination
ccuurrll:: ((2233)) FFaaiilluurree wwrriittiinngg oouuttppuutt ttoo ddeessttiinnaattiioonn
curl: (c2u3r)l :F a(i2l3u)r eF awirliutrien gw roiuttipnugt otuot pduets ttion adteisotni
nation
curl: (23) Failure writing output to destination |
I've put the text right in the related PRs. My assumption that |
Description
Resolves #2514 by switching the logic for resolving the full version to index.json instead of parsing the HTML index.
Motivation and Context
cc nodejs/release-cloudflare-worker#131
Testing Details
./update.shruns and outputs the expected versions still.Example Output(if appropriate)
N/A
Types of changes
Checklist