feat: Windows ARM64 target architecture support#331
feat: Windows ARM64 target architecture support#331larseggert wants to merge 2 commits intonodejs:mainfrom
Conversation
larseggert
changed the title
|
Failing test was fixed in: |
|
Would you mind rebasing on top of the main branch? Thank you! |
Extend the MSVC toolchain integration to support Windows ARM64 targets. (I know very little about gyp, so these changes may be a bit rough. They were enough to get NSS building on Windows 11/ARM in CI via mozilla/neqo#2591. Please let me know if anything needs changing!)
Co-authored-by: Christian Clauss <cclauss@me.com>
|
I don't have an ARM64 windows machine to verify this patch. As a follow-up, we could add an integration test for windows in https://github.com/nodejs/gyp-next/blob/main/test/integration_test.py. |
|
FWIW, GitHub now as Windows/ARM runners, so you can at least test in CI: https://github.com/actions/partner-runner-images/blob/main/images/arm-windows-11-image.md |
|
Yeah, we do run windows arm test with node-gyp. But the integration test is not run on windows arm. gyp-next/.github/workflows/node-gyp.yml Line 19 in 496bb0f Filed #335. |
|
@cclauss would you like to take another look? |
|
Syntax-wise I am OK with this, but I have never been a Windows user. |
3 participants
Extend the MSVC toolchain integration to support Windows ARM64 targets.
(I know very little about gyp, so these changes may be a bit rough. They were enough to get NSS building on Windows 11/ARM in CI via mozilla/neqo#2591. Please let me know if anything needs changing!)