Drop deprecated Python module pkg_resources#333
Merged
legendecas merged 1 commit intonodejs:mainfrom Mar 2, 2026
Merged
Conversation
pkg_resources
There was a problem hiding this comment.
Pull request overview
Updates gyp-next to remove use of the deprecated pkg_resources API and addresses a Ruff lint finding, keeping the CLI behavior intact while aligning with modern Python packaging APIs.
Changes:
- Replace
pkg_resources.get_distribution(...).versionwithimportlib.metadata.version(...)for--version. - Inline an unnecessary lambda (
key=lambda v: len(v)) tokey=lento satisfy RuffPLW0108.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pylib/gyp/__init__.py |
Switches version lookup from deprecated pkg_resources to importlib.metadata.version. |
pylib/gyp/mac_tool.py |
Simplifies max(..., key=...) by inlining len instead of a lambda. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 2, 2026
legendecas
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://setuptools.pypa.io/en/latest/deprecated/pkg_resources.html
Also fixes the
ruff rule PLW0108issue:pylib/gyp/mac_tool.py:548:61: PLW0108 Lambda may be unnecessary; consider inlining inner function
A subset of: