build, doc: drop support for Node.js v9.x#219
Closed
mmarchini wants to merge 2 commits intonodejs:masterfrom
Closed
build, doc: drop support for Node.js v9.x#219mmarchini wants to merge 2 commits intonodejs:masterfrom
mmarchini wants to merge 2 commits intonodejs:masterfrom
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
mmarchini
pushed a commit
that referenced
this pull request
Aug 9, 2018
PR-URL: #219 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mmarchini
pushed a commit
that referenced
this pull request
Aug 9, 2018
PR-URL: #219 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
Author
|
Landed in 5b6a6b5...65debbd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v9.x is EOL, we can remove it from our CI matrix. I also added names to our Travis jobs and reorganized
.travis.yml(inspired on https://github.com/elastic/apm-agent-nodejs/blob/09316fa7c33330b7264d376ab219e85dd384a97a/.travis.yml#L184-L264).