Add support for Android Termux build#243
Closed
jimgambale wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
mmarchini
reviewed
Oct 16, 2018
Contributor
mmarchini
left a comment
mmarchini
left a comment
There was a problem hiding this comment.
Have you tried running v8 ... commands? I tried v8 bt here and I got error: 'v8' is not a valid command.
Also, when I ran llnode node -c core I got:
(lldb) plugin load '/data/data/com.termux/files/usr/lib/node_modules/llnode/llnode.so'
error: this file does not represent a loadable dylib
| - Install Termux (https://termux.com) | ||
|
|
||
| - Install Termux Packages | ||
| - pkg install clang lldb lldb-dev liblldb |
Contributor
There was a problem hiding this comment.
liblldb is not available on Termux (and is not required apparently), can you please remove it? Also, I had to install make as well, can you please add it here?
Contributor
|
BTW, I think you can inspect a core dump generated in Termux/Android on Linux and OS X, you just need to get the core dump file as well as the node binary used to generate it. |
joyeecheung
approved these changes
Oct 17, 2018
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
LGTM with the doc changes suggested by @mmarchini
mmarchini
pushed a commit
that referenced
this pull request
Jan 18, 2019
PR-URL: #243 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Contributor
|
Landed in 59b65c4. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for Android Termux build
Tested with node v8.12.0