Add node-addon-api async iterator example#195
Merged
Conversation
KevinEady
requested review from
NickNaso,
gabrielschulhof,
legendecas and
mhdawson
Contributor
Author
KevinEady
force-pushed
the
async-iterator-example
branch
from
7552703 to
d70e386
Compare
Contributor
Author
|
Hi team, I realized that the first example I wrote is a bit contrived and probably not useful in real-world situations. I've created a new example that uses threadsafe functions which I think provides a better use-case in d70e386. |
legendecas
approved these changes
May 27, 2022
| } | ||
|
|
||
| private: | ||
| int _from; |
Member
There was a problem hiding this comment.
Nit: we may prefer to suffix with the underscore.
Suggested change
| int _from; | |
| int from_; |
Contributor
Author
There was a problem hiding this comment.
Hi @legendecas / @mhdawson ,
It looks like the standard used in napi.h for non-public members is to prefix with underscore (46 occurrences) versus suffix (1 occurrence), so I think I will stick with the prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An example as requested by nodejs/node-addon-api#1171