Skip to content

Fix Windows build by using windows-2019#196

Merged
KevinEady merged 1 commit intomainfrom
fix-windows-build
May 17, 2022
Merged

Fix Windows build by using windows-2019#196
KevinEady merged 1 commit intomainfrom
fix-windows-build

Conversation

@KevinEady
Copy link
Copy Markdown
Contributor

No description provided.

@KevinEady
Copy link
Copy Markdown
Contributor Author

The CI has been failing for some time now. I've tried doing various fixes for windows-latest such as setting msbuild path for node-gyp as well as upgrading node-gyp but could not get it to work. This seems to be a viable fix. Note that node-addon-api also uses windows-2019.

@KevinEady KevinEady merged commit c0285f9 into main May 17, 2022
@KevinEady KevinEady deleted the fix-windows-build branch May 17, 2022 19:07
@KevinEady
Copy link
Copy Markdown
Contributor Author

Hi @mhdawson ,

After merging this PR into master, I noticed there is a failure on the CI for Build and Deploy the Website. It appears to be failing since Sept 2021. Can you take a look...?

Thanks, Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants