feat: port test_general testFinalizer to CTS - #75
Open
bavulapati wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
testFinalizer.js, plus theunwrapbinding it needs.addFinalizerOnlycalls back into JS from a finalizer, which is only legal vianode_api_post_finalizer. That is experimental, so it builds as a separatetest_general_finalizeraddon gated onexperimentalFeatures.postFinalizer, leaving the stabletest_generaladdon loadable everywhere.Upstream calls
gc()once and relies on the exit-time check; this waits withgcUntilinstead, since the callbacks are posted rather than run inline during GC.Stacked on #72 - review that first.