Merged
Conversation
aduh95
force-pushed
the
pull-latest-commits-from-node-core
branch
from
421e986 to
fc19407
Compare
PR-URL: nodejs/node#43729 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> (cherry picked from commit 3aec7da5c6fcbedffdb034a9b7f6b60958b88d93)
PR-URL: nodejs/node#43505 Refs: nodejs/node#43490 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> (cherry picked from commit c1d659591d1c5a6002e762549ee46b69d495b70b)
PR-URL: nodejs/node#43757 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jacob Smith <jacob@frende.me> (cherry picked from commit a3766bc8a84bcd375372a0a5c8c9174dadb6817d)
aduh95
force-pushed
the
pull-latest-commits-from-node-core
branch
from
fc19407 to
2d96ae4
Compare
aduh95
force-pushed
the
pull-latest-commits-from-node-core
branch
from
2d96ae4 to
51438b7
Compare
MoLow
approved these changes
Jul 20, 2022
Add a warning to clarify that it is not a reliable mechanism for cancelling tests. Fix the default value of the timeout option. Simplify and capitalize the YAML description field. PR-URL: nodejs/node#43836 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> (cherry picked from commit 545ecc57360fad50c49c81b56ae25fcc99d38456)
aduh95
force-pushed
the
pull-latest-commits-from-node-core
branch
from
51438b7 to
751ffc6
Compare
MoLow
approved these changes
Jul 20, 2022
Member
MoLow
left a comment
MoLow
left a comment
There was a problem hiding this comment.
I Wonder if this package can polyfill less parts of node core such of timeout promises,
But that can probably be done separately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as draft as there are several followup commits that should land on node that we want to include.