fix(test): ensure all tests are run and fix failing ones#33
Merged
aduh95 merged 1 commit intonodejs:mainfrom Jul 30, 2022
Merged
fix(test): ensure all tests are run and fix failing ones#33aduh95 merged 1 commit intonodejs:mainfrom
aduh95 merged 1 commit intonodejs:mainfrom
Conversation
MoLow
reviewed
Jul 30, 2022
| const PARALLEL_DIR = new URL('./parallel/', import.meta.url) | ||
| const dir = await fs.opendir(PARALLEL_DIR) | ||
|
|
||
| for await (const { name } of dir) { |
Member
There was a problem hiding this comment.
this is kind of what node --test does but I understand why we relying on it is risky here
MoLow
approved these changes
Jul 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure what was
node test/parallel/*suppose to do, but clearly it wasn't reporting test failures. Instead I created a small script that execute all the files one by one (which makes "parallel" a very bad name for it, but that's also much easier to setup so here you go).