Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 9, 2025

One frustration I have since I switched to an encrypted config file is that I have to type my passphrase when the tool doesn't need access to any sensitive information (e.g. my gh handle). This PR should solve this by only asking my passphrase when it's needed, telling me why it's needed.

@codecov
Copy link

codecov bot commented Nov 9, 2025

Codecov Report

❌ Patch coverage is 58.77193% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.65%. Comparing base (2589b9c) to head (6790897).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/config.js 48.07% 27 Missing ⚠️
lib/auth.js 67.74% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
+ Coverage   79.72%   80.65%   +0.93%     
==========================================
  Files          39       39              
  Lines        4675     4746      +71     
==========================================
+ Hits         3727     3828     +101     
+ Misses        948      918      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 requested a review from joyeecheung November 15, 2025 11:03
@joyeecheung joyeecheung merged commit 7342aff into nodejs:main Nov 15, 2025
12 of 13 checks passed
@aduh95 aduh95 deleted the partially-encrypted-config-files branch November 15, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants