Skip to content

fix(*): throw Error objects to help with debugging#1045

Merged
aduh95 merged 3 commits intonodejs:mainfrom
aduh95:throw-errors
Mar 27, 2026
Merged

fix(*): throw Error objects to help with debugging#1045
aduh95 merged 3 commits intonodejs:mainfrom
aduh95:throw-errors

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Mar 22, 2026

Since #990, we really have no reason not to throw genuine Error objects.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.56%. Comparing base (5034b4f) to head (b6bdada).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
lib/auth.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
- Coverage   80.93%   80.56%   -0.38%     
==========================================
  Files          39       39              
  Lines        4841     4846       +5     
==========================================
- Hits         3918     3904      -14     
- Misses        923      942      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented Mar 24, 2026

Ping @nodejs/node-core-utils for reviews

@aduh95 aduh95 merged commit 25082a4 into nodejs:main Mar 27, 2026
12 of 13 checks passed
@aduh95 aduh95 deleted the throw-errors branch March 27, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants