fix(v8): set RUSTC_BOOTSTRAP=1 when using Cargo nightly features - #1127
Merged
Conversation
We need to enable `-Z bindeps` to read the Chromium crates tree, but this is not available on Cargo release builds by default. Setting RUSTC_BOOTSTRAP overrides this behaviour. This is technically an unstable feature, but Chromium's tooling also uses it for the same purpose, and it's extremely unlikely to be withdrawn. Co-authored-by: Michaël Zasso <targos@protonmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1127 +/- ##
=======================================
Coverage 57.32% 57.32%
=======================================
Files 53 53
Lines 10368 10368
=======================================
Hits 5943 5943
Misses 4425 4425 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
targos
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to enable
-Z bindepsto read the Chromium crates tree, but this is not available on Cargo release builds by default. Setting RUSTC_BOOTSTRAP overrides this behaviour.This is technically an unstable feature, but Chromium's tooling also uses it for the same purpose, and it's extremely unlikely to be withdrawn.
Refs: #1117 (review)