Skip to content

chore: remove EoL Node.js 16 from test matrix #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 24, 2023
Merged

chore: remove EoL Node.js 16 from test matrix #733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f0365f
chore: remove EoL Node.js 16 from test matrix
rluvaton Sep 22, 2023
42fb736
chore: update engines in package.json
rluvaton Sep 23, 2023
cd5c4f9
chore: moved to prepare-node-test-matrix
rluvaton Sep 23, 2023
84fe43f
chore: remove support from node 16,17 and 19
rluvaton Sep 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 8 additions & 22 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,27 +22,13 @@ jobs:
run: npm run lint

test:
name: Test on Node.js ${{ matrix.node-version }} and ${{ matrix.os }}
name: Test on Node.js
uses: pkgjs/action/.github/workflows/node-test.yaml@v0
with:
runs-on: ubuntu-latest, macos-latest
test-command: npm run coverage:ci
post-test-steps: |
- name: Upload coverage report to Codecov
uses: codecov/codecov-action@v3
strategy:
fail-fast: false
matrix:
node-version: [16.x, 18.x, 20.x]
os: [ubuntu-latest, macOS-latest, windows-latest]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
check-latest: true
- name: Install dependencies
run: npm install
- name: Run tests
if: matrix.node-version == '16.x'
run: npm run test-unit
- name: Run tests
if: matrix.node-version != '16.x'
run: npm run coverage:ci
- name: Upload coverage report to Codecov
uses: codecov/codecov-action@v3
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Utilities for Node.js core collaborators",
"type": "module",
"engines": {
"node": ">=16.8.0"
"node": "^18.18.0 || >=20.0.0"
},
"bin": {
"get-metadata": "./bin/get-metadata.js",
Expand Down