buffer: always let indexOf look at odd indexes - #26594
Closed
seishun wants to merge 1 commit into
Closed
Conversation
Previously, buffer.indexOf would look only at even indexes when the encoding is UTF-16. This behavior is undocumented and unintuitive. Detemplatize string_search.h because it is now used with only one type. Fixes: #26448
nodejs-github-bot
added
buffer
BridgeAR
added
the
semver-major
Member
|
@nodejs/buffer |
jasnell
approved these changes
Mar 31, 2019
BridgeAR
self-requested a review
April 3, 2019 02:36
Member
|
I'm cleaning out a few old PRs 🧹. I'm closing this due to inactivity. Please re-open if needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, buffer.indexOf would look only at even indexes when the
encoding is UTF-16. This behavior is undocumented and unintuitive.
Detemplatize string_search.h because it is now used with only one type.
Fixes: #26448
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes