stream: update readable.map test to use node:test

[rluvaton]

this is part of a bigger question: should node use its own testing?

if so, this is the first step

If speaking from DX's point of view I think it should be as the tooling is only going to get better, and you going to have an easier way of writing and executing tests IMO

[debadree25]

Would it conflict with the python test runner we use? If we do this also we would have to migrate all tests no? some test in node:test some tests in legacy then

[cjihrig]

this is part of a bigger question: should node use its own testing?

Some people have started writing new tests using node:test. Other people prefer not to because writing a plain JS file is pretty easy. This was discussed a bit in #44288

Would it conflict with the python test runner we use?

There is already some mixture of the two test runners that seems to work well enough.

If we do this also we would have to migrate all tests no?

No. This would be a massive amount of churn that doesn't accomplish much IMO and is likely to introduce backporting conflicts. Additionally, the state of the test runner is different on the various release lines which could also introduce friction.

[MoLow]

Would it conflict with the python test runner we use? If we do this also we would have to migrate all tests no?

no, it won't. the python test runner really only cares about the process exit code

[MoLow]

LGTM, but the commit message should start with test:, not stream:

[debadree25]

Ah thanks for explaining! if it doesnt then i think this is good then!

[aduh95]

Rewriting existing tests is high risk, low reward. I’m generally -0 on these kind of proposals, and also the test runner node --test works fine with plain JS files, migrating to using node:test in the test files is not a requirement for moving away from the Python runner (if that was the goal).

[rluvaton]

Will close this than 😄