esm: protect against removal of "beforeExit" event handler

[aduh95]

tbh I'm not sure if that's a good idea, it's still quite brittle because hooks authors could still remove the removeListener listener (e.g. by calling process.removeAllListeners()), and at some point there's no way around it – or at least, I didn't find a way. I'm opening this in case someone has a better solution they'd want to share.

[nodejs-github-bot]

Review requested:

• @nodejs/loaders
• @nodejs/modules

[GeoffreyBooth]

What problem is this solving?

If you’re intending to prevent them from removing the event handler, yet they still can, how is this an improvement? Yes they need to make a different call to do so, but if someone is trying to break things and they still are able to, I’m not sure we’ve achieved anything.

[aduh95]

@GeoffreyBooth did you miss the "I'm opening this in case someone has a better solution they'd want to share" part of the OP?

[GeoffreyBooth]

@GeoffreyBooth did you miss the “I’m opening this in case someone has a better solution they’d want to share” part of the OP?

No, I didn’t.

[ljharb]

… wait, why is removeAllListeners a thing? The web doesn't have this precisely because it's an encapsulation violation.

[targos]

@ljharb It's been in Node.js since version 0.1.32: f8eb163

[aduh95]

I guess we can triage this in "known limitations"