doc:add documentation for the object fields return with fs.fstat#48620
Open
talvaknin744 wants to merge 1 commit intonodejs:mainfrom
Open
doc:add documentation for the object fields return with fs.fstat#48620talvaknin744 wants to merge 1 commit intonodejs:mainfrom
talvaknin744 wants to merge 1 commit intonodejs:mainfrom
Conversation
add documentation for the object fields return with fs.fstat
nodejs-github-bot
added
doc
aduh95
reviewed
Jul 2, 2023
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Thanks for the pull request! I'm not sure this is an addition we would like to do in this section, if the user follows the link to fs.Stats, they can already find an example of what such object contains. The issue of duplicating the data here is that it makes it more probable that one section or the other will drift off eventually if ever to add or remove properties to fs.Stats objects.
Author
|
Thank you for your contribution. This pull request addresses bug #48574, as requested by @bnoordhuis. I appreciate your comment. Because of the changes, would it be best to close the pull request or mark it resolved? |
Member
|
I would just add a link to https://linux.die.net/man/2/fstat as suggested in #48574 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add documentation for the object fields return with fs.fstats