Skip to content

src: node.h signal.h to csignal#48723

Open
CGQAQ wants to merge 2 commits intonodejs:mainfrom
CGQAQ:fix-node-h-header-deprecation
Open

src: node.h signal.h to csignal#48723
CGQAQ wants to merge 2 commits intonodejs:mainfrom
CGQAQ:fix-node-h-header-deprecation

Conversation

@CGQAQ
Copy link
Contributor

@CGQAQ CGQAQ commented Jul 10, 2023

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jul 10, 2023
@bnoordhuis
Copy link
Member

Okay, but why? Contextless changes are unlikely to get merged.

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Jul 10, 2023

Okay, but why? Contextless changes are unlikely to get merged.

@bnoordhuis It has warnings about the deprecated header, and in that file, all other header included is cpp style with no .h extension.

image
image

The comment change is because it was #ifndef , we already have the !_WIN32 comment a couple of lines below
image

@aduh95
Copy link
Contributor

aduh95 commented Jul 15, 2023

Can you please consider sharing links to code, rather than screenshots? Screenshots can be harder to read (for folks using screen readers, or if the color scheme you're using is not accessible to some visual impairments), and consume more data to download. Links are also better at giving context.

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Jul 17, 2023

But I cannot show the warning without screenshots

@anonrig
Copy link
Member

anonrig commented Jul 19, 2023

a link to the clang-tidy rule would be helpful

@CGQAQ
Copy link
Contributor Author

CGQAQ commented Jul 21, 2023

a link to the clang-tidy rule would be helpful

Added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants