test_runner: add stack on unhandled rejections#51751
Closed
atlowChemi wants to merge 1 commit intonodejs:mainfrom
Closed
test_runner: add stack on unhandled rejections#51751atlowChemi wants to merge 1 commit intonodejs:mainfrom
atlowChemi wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MoLow
reviewed
Feb 13, 2024
MoLow
reviewed
Feb 13, 2024
aduh95
approved these changes
Feb 14, 2024
MoLow
approved these changes
Feb 14, 2024
marco-ippolito
approved these changes
Feb 14, 2024
mertcanaltin
approved these changes
Feb 14, 2024
github-actions
bot
removed
the
request-ci
Collaborator
lpinca
approved these changes
Feb 14, 2024
atlowChemi
force-pushed
the
test-runner-handler-add-stack
branch
from
759b0a2 to
3ee0d83
Compare
atlowChemi
force-pushed
the
test-runner-handler-add-stack
branch
from
3ee0d83 to
1681786
Compare
mertcanaltin
approved these changes
Apr 16, 2024
github-actions
bot
removed
the
request-ci
Collaborator
benjamingr
approved these changes
Apr 17, 2024
Contributor
|
@atlowChemi are you still planning to work on this? If not, can we close it out? |
Member
Author
@cjihrig I was unable to figure out the issue with the stack trace on windows, and I don't currently have the time to investigate this, so I don't think I'll be looking at it anytime soon... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #51714