Skip to content

Comments

test: update WPT for url to 9504a83e01#57487

Closed
nodejs-github-bot wants to merge 3 commits intomainfrom
actions/update-url-wpt
Closed

test: update WPT for url to 9504a83e01#57487
nodejs-github-bot wants to merge 3 commits intomainfrom
actions/update-url-wpt

Conversation

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Mar 16, 2025

This is an automated update of the WPT for url to web-platform-tests/wpt@9504a83.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 16, 2025
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/url
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 16, 2025
@codecov
Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (824c6a5) to head (c17e0ca).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57487      +/-   ##
==========================================
- Coverage   90.23%   90.23%   -0.01%     
==========================================
  Files         629      629              
  Lines      184955   184939      -16     
  Branches    36215    36228      +13     
==========================================
- Hits       166901   166885      -16     
- Misses      11012    11033      +21     
+ Partials     7042     7021      -21     

see 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
Copy link
Contributor

aduh95 commented Mar 16, 2025

@nodejs/url looks like there are failures, how should this PR proceed?

@anonrig
Copy link
Member

anonrig commented Mar 16, 2025

@nodejs/url looks like there are failures, how should this PR proceed?

For now, we should add the failing tests to expected failures and fix them in Ada. I can follow up to fix them in Ada, soon.

@nodejs-github-bot nodejs-github-bot changed the title test: update WPT for url to 072413fba2 test: update WPT for url to 9504a83e01 Mar 19, 2025
@aduh95
Copy link
Contributor

aduh95 commented Mar 27, 2025

Closing as there are conflicts

@aduh95 aduh95 closed this Mar 27, 2025
@aduh95 aduh95 deleted the actions/update-url-wpt branch March 27, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants