Skip to content

Conversation

@jazelly
Copy link
Member

@jazelly jazelly commented May 9, 2025

No description provided.

@jazelly jazelly force-pushed the fix-typed-array-type branch from d8a0b28 to 382f33f Compare May 9, 2025 03:24
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this one in particular? Looking at https://tc39.es/ecma262/#sec-properties-of-the-%typedarrayprototype%-object there are many that are missing – and I guess that's fine as long as we're not using them

@jazelly
Copy link
Member Author

jazelly commented May 9, 2025

No specific reason : ) just saw this while looking at the lib/buffer.js code.

TypedArrayPrototypeFill(buffer, 0, pos, length);

Didn't check if other functions that might be missing. Maybe it's a good time to do so tho.

@jazelly
Copy link
Member Author

jazelly commented May 9, 2025

Actually you are right, there are many TypedArray methods we used without typing. I'll re-raise this for the domain together.

@jazelly jazelly closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants