test: fix incorrect calculation in test-perf-hooks.js #60271
Merged
+14
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
joyeecheung
force-pushed
the
fix-origin
branch
from
72c3df2 to
3452025
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60271 +/- ##
==========================================
- Coverage 88.57% 88.55% -0.03%
==========================================
Files 704 704
Lines 208323 208323
Branches 40037 40034 -3
==========================================
- Hits 184531 184487 -44
- Misses 15811 15867 +56
+ Partials 7981 7969 -12 🚀 New features to boost your workflow:
|
After https://redirect.github.com/nodejs/node/pull/46588, Date.now() - performance.timeOrigin and process.uptime() are no longer similar - the former measures uptime from process initilaization, while the latter measures uptime from the main context initialization. Account for the differences in the test.
joyeecheung
force-pushed
the
fix-origin
branch
from
3452025 to
b241008
Compare
lpinca
approved these changes
Oct 16, 2025
joyeecheung
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/60271 ✔ Done loading data for nodejs/node/pull/60271 ----------------------------------- PR info ------------------------------------ Title test: fix incorrect calculation in test-perf-hooks.js (#60271) Author Joyee Cheung <joyeec9h3@gmail.com> (@joyeecheung) Branch joyeecheung:fix-origin -> nodejs:main Labels test, needs-ci Commits 1 - test: fix incorrect calculation in test-perf-hooks.js Committers 1 - Joyee Cheung <joyeec9h3@gmail.com> PR-URL: https://github.com/nodejs/node/pull/60271 Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-15.md Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60271 Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-15.md Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 15 Oct 2025 19:35:30 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/60271#pullrequestreview-3346513209 ✘ This PR needs to wait 107 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-10-18T05:36:48Z: https://ci.nodejs.org/job/node-test-pull-request/69806/ - Querying data for job/node-test-pull-request/69806/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/18612987296 |
joyeecheung
added
review wanted
UlisesGascon
approved these changes
Oct 18, 2025
joyeecheung
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 649d73a |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2025
After https://redirect.github.com/nodejs/node/pull/46588, Date.now() - performance.timeOrigin and process.uptime() are no longer similar - the former measures uptime from process initilaization, while the latter measures uptime from the main context initialization. Account for the differences in the test. PR-URL: #60271 Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-15.md Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After https://redirect.github.com/nodejs/node/pull/46588, Date.now() - performance.timeOrigin and process.uptime() are no longer similar - the former measures uptime from process initilaization, while the latter measures uptime from the main context initialization. Account for the differences in the test.
This failed 11 PRs out of the last 100 CI runs in the latest reliability report.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-15.md