Skip to content

Conversation

@legendecas
Copy link
Member

test/parallel/test-debugger-exceptions.js is flaky on macOS in GitHub Action workflow.
Increase the timeout to reduce the flakyness.

Refs: https://github.com/nodejs/node/actions/runs/18694915575/job/53309761263?pr=60343

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 22, 2025
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (2fb82c8) to head (672c34a).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60367      +/-   ##
==========================================
- Coverage   88.59%   88.57%   -0.03%     
==========================================
  Files         704      704              
  Lines      208474   208398      -76     
  Branches    40067    40057      -10     
==========================================
- Hits       184696   184581     -115     
- Misses      15805    15836      +31     
- Partials     7973     7981       +8     

see 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2025
@nodejs-github-bot
Copy link
Collaborator

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2025
@nodejs-github-bot nodejs-github-bot merged commit 2bda7cb into nodejs:main Oct 24, 2025
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 2bda7cb

@legendecas legendecas deleted the test-macos-debugger branch October 24, 2025 14:41
aduh95 pushed a commit that referenced this pull request Oct 26, 2025
PR-URL: #60367
Refs: https://github.com/nodejs/node/actions/runs/18694915575/job/53309761263?pr=60343
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants