-
-
Couldn't load subscription status.
- Fork 33.6k
test: increase debugger waitFor timeout on macOS #60367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 2 commits into
nodejs:main
from
legendecas:test-macos-debugger
Oct 24, 2025
Merged
test: increase debugger waitFor timeout on macOS #60367
nodejs-github-bot
merged 2 commits into
nodejs:main
from
legendecas:test-macos-debugger
Oct 24, 2025
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Oct 22, 2025
Co-authored-by: Colin Ihrig <cjihrig@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60367 +/- ##
==========================================
- Coverage 88.59% 88.57% -0.03%
==========================================
Files 704 704
Lines 208474 208398 -76
Branches 40067 40057 -10
==========================================
- Hits 184696 184581 -115
- Misses 15805 15836 +31
- Partials 7973 7981 +8 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Oct 22, 2025
gurgunday
approved these changes
Oct 22, 2025
joyeecheung
approved these changes
Oct 22, 2025
|
Landed in 2bda7cb |
aduh95
pushed a commit
that referenced
this pull request
Oct 26, 2025
PR-URL: #60367 Refs: https://github.com/nodejs/node/actions/runs/18694915575/job/53309761263?pr=60343 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/parallel/test-debugger-exceptions.jsis flaky on macOS in GitHub Action workflow.Increase the timeout to reduce the flakyness.
Refs: https://github.com/nodejs/node/actions/runs/18694915575/job/53309761263?pr=60343