Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 13, 2025

Documentation around Web Storage is kinda all over the place, IMO we're really not making a good job at presenting the experimental aspect of it.

  • in src,lib,test: unflag --experimental-webstorage by default #57666, the flag was renamed to remove the "experimental" part of it. I think that was a mistake.
  • the history sections in the docs are not mentioning the fact it's no longer behind the flag.
  • some sections were straight up missing the experimental status badge, or mentioning stability 1.0 despite the fact the API is now unflagged.
  • adding a history entry for the throw behavior that was reintroduced recently.

@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Nov 13, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Nov 13, 2025
@aduh95 aduh95 added backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. needs-ci PRs that need a full CI run. config Issues or PRs related to the config subsystem and removed c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. needs-ci PRs that need a full CI run. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. config Issues or PRs related to the config subsystem dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (d546e7f) to head (be312f1).
⚠️ Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60708      +/-   ##
==========================================
- Coverage   88.53%   88.52%   -0.02%     
==========================================
  Files         703      703              
  Lines      208218   208222       +4     
  Branches    40140    40137       -3     
==========================================
- Hits       184351   184319      -32     
- Misses      15862    15900      +38     
+ Partials     8005     8003       -2     
Files with missing lines Coverage Δ
lib/internal/process/pre_execution.js 98.53% <100.00%> (ø)
src/node_options.cc 77.75% <100.00%> (-0.11%) ⬇️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: René <contact.9a5d6388@renegade334.me.uk>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 16, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 16, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/60708
✔  Done loading data for nodejs/node/pull/60708
----------------------------------- PR info ------------------------------------
Title      doc,src,lib: clarify experimental status of Web Storage support (#60708)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:experimental-web-storage -> nodejs:main
Labels     c++, process, author ready, needs-ci, dont-land-on-v20.x, backport-requested-v22.x, config, backport-requested-v24.x
Commits    3
 - doc,src,lib: clarify experimental status of Web Storage support
 - Update doc/api/globals.md
 - Update doc/api/globals.md
Committers 2
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
 - GitHub <noreply@github.com>
PR-URL: https://github.com/nodejs/node/pull/60708
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60708
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 13 Nov 2025 21:05:51 GMT
   ✔  Approvals: 2
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/60708#pullrequestreview-3468018245
   ✔  - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/60708#pullrequestreview-3470218448
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-11-16T14:02:45Z: https://ci.nodejs.org/job/node-test-pull-request/70204/
- Querying data for job/node-test-pull-request/70204/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 60708
From https://github.com/nodejs/node
 * branch                  refs/pull/60708/merge -> FETCH_HEAD
✔  Fetched commits as 33b1574cbf65..be312f1d8221
--------------------------------------------------------------------------------
Auto-merging doc/api/cli.md
[main cd67f3ac95] doc,src,lib: clarify experimental status of Web Storage support
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Thu Nov 13 21:55:21 2025 +0100
 5 files changed, 42 insertions(+), 22 deletions(-)
[main 92e7991e03] Update doc/api/globals.md
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Fri Nov 14 14:04:20 2025 +0100
 1 file changed, 8 insertions(+), 3 deletions(-)
[main b6ce41b2bd] Update doc/api/globals.md
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Fri Nov 14 14:05:24 2025 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
(node:2255) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc,src,lib: clarify experimental status of Web Storage support

PR-URL: #60708
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

[detached HEAD b401ee3d57] doc,src,lib: clarify experimental status of Web Storage support
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Thu Nov 13 21:55:21 2025 +0100
5 files changed, 42 insertions(+), 22 deletions(-)
Rebasing (3/6)
Rebasing (4/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/globals.md

Co-authored-by: René <contact.9a5d6388@renegade334.me.uk>
PR-URL: #60708
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

[detached HEAD 5031d2d7da] Update doc/api/globals.md
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Fri Nov 14 14:04:20 2025 +0100
1 file changed, 8 insertions(+), 3 deletions(-)
Rebasing (5/6)
Rebasing (6/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/globals.md

PR-URL: #60708
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>

[detached HEAD 5dcd4939a0] Update doc/api/globals.md
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Fri Nov 14 14:05:24 2025 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/19407453874

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 16, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 16, 2025
@nodejs-github-bot nodejs-github-bot merged commit 3330e5c into nodejs:main Nov 16, 2025
82 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3330e5c

@aduh95 aduh95 deleted the experimental-web-storage branch November 16, 2025 15:03
aduh95 added a commit that referenced this pull request Nov 16, 2025
PR-URL: #60708
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
aduh95 added a commit that referenced this pull request Nov 17, 2025
PR-URL: #60708
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@aduh95 aduh95 added lts-watch-v22.x PRs that may need to be released in v22.x backported-to-v24.x PRs backported to the v24.x-staging branch. and removed backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. labels Nov 17, 2025
aduh95 added a commit that referenced this pull request Nov 17, 2025
PR-URL: #60708
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@aduh95 aduh95 added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed lts-watch-v22.x PRs that may need to be released in v22.x labels Nov 17, 2025
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Nov 18, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | patch | `25.2.0` -> `25.2.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>nodejs/node (node)</summary>

### [`v25.2.1`](https://github.com/nodejs/node/releases/tag/v25.2.1): 2025-11-17, Version 25.2.1 (Current), @&#8203;aduh95

[Compare Source](nodejs/node@v25.2.0...v25.2.1)

This release reverts the spec-compliant behavior of sometimes throwing on `localStorage`
access. We received feedback that this change on an experimental API was too breaking
for a semver-minor release, so we decided to push it back for Node.js 26.0.0.

##### Commits

- \[[`ff89b7b6c7`](nodejs/node@ff89b7b6c7)] - **crypto**: ensure documented RSA-PSS saltLength default is used (Filip Skokan) [#&#8203;60662](nodejs/node#60662)
- \[[`5316b580eb`](nodejs/node@5316b580eb)] - **deps**: V8: backport [`2e4c5cf`](nodejs/node@2e4c5cf9b112) (Michaël Zasso) [#&#8203;60654](nodejs/node#60654)
- \[[`ca878bc90e`](nodejs/node@ca878bc90e)] - **doc,src,lib**: clarify experimental status of Web Storage support (Antoine du Hamel) [#&#8203;60708](nodejs/node#60708)
- \[[`a4dee613fd`](nodejs/node@a4dee613fd)] - ***Revert*** "**lib**: throw from localStorage getter on missing storage path" (Antoine du Hamel) [#&#8203;60750](nodejs/node#60750)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v22.x PRs backported to the v22.x-staging branch. backported-to-v24.x PRs backported to the v24.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. config Issues or PRs related to the config subsystem dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants