Skip to content

test: use RegExp.escape to improve test reliability #60803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 23, 2025
Merged

test: use RegExp.escape to improve test reliability #60803

merged 3 commits into from
Nov 23, 2025

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 21, 2025

No description provided.

@aduh95 aduh95 added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Nov 21, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 21, 2025

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (d729bec) to head (496cf72).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60803      +/-   ##
==========================================
- Coverage   88.55%   88.54%   -0.01%     
==========================================
  Files         703      703              
  Lines      208259   208254       -5     
  Branches    40162    40154       -8     
==========================================
- Hits       184415   184393      -22     
- Misses      15844    15845       +1     
- Partials     8000     8016      +16

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 22, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70272/

@aduh95 aduh95 marked this pull request as draft November 22, 2025 09:21
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 22, 2025

Windows CI failure's definitely related

@benjamingr
Copy link
Member

benjamingr commented Nov 22, 2025

(with the test fixed, of course)

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 22, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70275/

@aduh95 aduh95 marked this pull request as ready for review November 22, 2025 20:13
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 22, 2025
gurgunday
gurgunday approved these changes Nov 22, 2025
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2025
@nodejs-github-bot nodejs-github-bot merged commit 8dc2bdd into nodejs:main Nov 23, 2025
87 of 89 checks passed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 23, 2025

Landed in 8dc2bdd

@aduh95 aduh95 deleted the RegExp.escape branch November 23, 2025 19:28
targos pushed a commit that referenced this pull request Nov 27, 2025
@aduh95 @targos
test: use RegExp.escape to improve test reliability
fad3186 
PR-URL: #60803
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

+1 more reviewer

@gurgunday gurgunday gurgunday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aduh95 @nodejs-github-bot @benjamingr @lpinca @cjihrig @gurgunday @LiviaMedeiros