Revert "util: add fast path for Latin1 decoding"

[ChALkeR]

This reverts commit 20bcaa0 (#55275)

Fixes: #60888
Fixes: #59515
Fixes: #56542
Refs: #55275 (comment)
Refs: #55275 (comment)

[nodejs-github-bot]

Review requested:

• @nodejs/performance

[mcollina]

lgtm

[mcollina]

cc @mertcanaltin maybe there is an alternative fix.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70337/

[mertcanaltin]

Thanks for catching this. I'm sorry for the trouble this has caused. Thank you for the detailed explanation, @ChALkeR.

@mcollina Thanks for the ping. I'll look into an alternative fix - I think separate mappings for the two encodings would be a good solution.

[ChALkeR]

@mertcanaltin Is there any encoding in TextDecoder API which can utilize the Latin1 codepath?
My assumption is no, hence the removal of that method (as nothing else uses it)

[mertcanaltin]

@mertcanaltin Is there any encoding in TextDecoder API which can utilize the Latin1 codepath? My assumption is no, hence the removal of that method (as nothing else uses it)

Yes, I just checked, and as you said, there is no valid use case for the Latin1 method in the TextDecoder API, so it can be removed.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (d1ab5ef) to head (a76afd8).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #60889   +/-   ##
=======================================
  Coverage   88.55%   88.56%           
=======================================
  Files         703      703           
  Lines      208291   208250   -41     
  Branches    40174    40156   -18     
=======================================
- Hits       184454   184429   -25     
+ Misses      15829    15826    -3     
+ Partials     8008     7995   -13     

Files with missing lines	Coverage Δ
lib/internal/encoding.js	99.50% <100.00%> (-0.01%)	⬇️
src/encoding_binding.cc	84.13% <ø> (+4.92%)	⬆️
src/encoding_binding.h	100.00% <ø> (ø)

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mertcanaltin]

I tried a fix #60893
@mcollina @ChALkeR

[ChALkeR]

I think this should be separate PRs, because:

1. DecodeLatin1 is unused and can be removed, which src: implement Windows-1252 encoding support and update related tests #60893 doesn't do but this PR does. Upd: fixed
2. To make backporting easier

Also tests from #58890 would be helpful (upd: #60893 covers that now!)

No objection for going ahead and landing #60893 though, but then it has to be backported to all branches which regressed

[ChALkeR]

Let's go with #60893, it looks cleaner after an update

Not closing this PR until that lands though in case something arises on review

[mertcanaltin]

Let's go with #60893, it looks cleaner after an update

Not closing this PR until that lands though in case something arises on review

Okay, thank you very much for your support and details. It was great working with you. 🚀