Skip to content

Conversation

@mertcanaltin
Copy link
Member

@mertcanaltin mertcanaltin commented Nov 29, 2025

Alternative for this pr: #60889

this pr deleted decodeLatin1, and added Windows-1252 encoding support

problem: #60888

Thanks for repair & info detail 🙏 @ChALkeR

cc @mcollina

Fixes: #60888
Fixes: #59515
Fixes: #56542

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. needs-ci PRs that need a full CI run. typings labels Nov 29, 2025
@mertcanaltin
Copy link
Member Author

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any reasons to keep DecodeLatin1? It seems unused

@mertcanaltin mertcanaltin force-pushed the mert/fix/windows-1252-decoding branch from 709e9ce to 25319d5 Compare November 29, 2025 18:11
@mertcanaltin
Copy link
Member Author

Are there any reasons to keep DecodeLatin1? It seems unused

I removed DecodeLatin1, thanks

@mertcanaltin mertcanaltin force-pushed the mert/fix/windows-1252-decoding branch from 848e480 to 59fd7cb Compare November 29, 2025 18:28
@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

❌ Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.56%. Comparing base (768f3ba) to head (59fd7cb).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/encoding_binding.cc 81.81% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #60893   +/-   ##
=======================================
  Coverage   88.56%   88.56%           
=======================================
  Files         703      703           
  Lines      208291   208302   +11     
  Branches    40169    40160    -9     
=======================================
+ Hits       184472   184482   +10     
- Misses      15831    15841   +10     
+ Partials     7988     7979    -9     
Files with missing lines Coverage Δ
lib/internal/encoding.js 99.51% <100.00%> (ø)
src/encoding_binding.h 100.00% <ø> (ø)
src/encoding_binding.cc 80.95% <81.81%> (+1.73%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. needs-ci PRs that need a full CI run. typings

Projects

None yet

4 participants