-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
src: implement Windows-1252 encoding support and update related tests #60893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
src: implement Windows-1252 encoding support and update related tests #60893
Conversation
|
I think this test type is flakky https://github.com/nodejs/node/actions/runs/19785758751/job/56691976357?pr=60893 |
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
ChALkeR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any reasons to keep DecodeLatin1? It seems unused
709e9ce to
25319d5
Compare
I removed DecodeLatin1, thanks |
848e480 to
59fd7cb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60893 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 703 703
Lines 208291 208302 +11
Branches 40169 40160 -9
=======================================
+ Hits 184472 184482 +10
- Misses 15831 15841 +10
+ Partials 7988 7979 -9
🚀 New features to boost your workflow:
|
Alternative for this pr: #60889
this pr deleted decodeLatin1, and added Windows-1252 encoding support
problem: #60888
Thanks for repair & info detail 🙏 @ChALkeR
cc @mcollina
Fixes: #60888
Fixes: #59515
Fixes: #56542