fix: prevent V8 tool scripts from being loaded as builtin modules #60894
+14
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prevents Node.js from attempting to load V8 tool scripts under
internal/deps/v8/tools/as builtin modules.These files are part of V8’s internal tooling and are not valid Node.js
builtins. When required or imported with
--expose-internals, the loaderattempts to treat them as builtin CJS modules, which results in either:
(because the V8 tool scripts contain ESM syntax), or
(
data->IsValue()), aborting the process.This change adds a guard in
loadBuiltinModule()to skip any module whosepath starts with
internal/deps/v8/tools/, and also adds a defensive checkto avoid calling
compileForPublicLoader()when no builtin module entryexists.
This aligns the behavior with expectations and avoids a crash when users
attempt to load these paths with
--expose-internals.Fixes: #60865