watch: fix --env-file-if-exists crashing on linux if the file is missing#61870
Open
efekrskl wants to merge 9 commits intonodejs:mainfrom
Open
watch: fix --env-file-if-exists crashing on linux if the file is missing#61870efekrskl wants to merge 9 commits intonodejs:mainfrom
efekrskl wants to merge 9 commits intonodejs:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61870 +/- ##
==========================================
- Coverage 89.72% 89.66% -0.06%
==========================================
Files 675 676 +1
Lines 204806 206347 +1541
Branches 39355 39534 +179
==========================================
+ Hits 183761 185021 +1260
- Misses 13330 13458 +128
- Partials 7715 7868 +153
🚀 New features to boost your workflow:
|
aduh95
reviewed
Feb 18, 2026
anonrig
reviewed
Feb 18, 2026
anonrig
reviewed
Feb 19, 2026
anonrig
reviewed
Feb 19, 2026
anonrig
reviewed
Feb 19, 2026
Contributor
Author
|
@anonrig I've addressed all comments. I've also documented the change in Also, thanks a lot for the quick and detailed feedback! |
aduh95
reviewed
Mar 4, 2026
aduh95
reviewed
Mar 4, 2026
aduh95
approved these changes
Mar 9, 2026
anonrig
approved these changes
Mar 10, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57040
--env-file-if-exists combined with --watch seems to crash in if the .env file is missing (in Linux), this PR aims to fix that.