Skip to content

inspector: add Target.getTargets and extract TargetManager#62487

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
cola119:feature/target_getTargets
Mar 31, 2026
Merged

inspector: add Target.getTargets and extract TargetManager#62487
nodejs-github-bot merged 1 commit intonodejs:mainfrom
cola119:feature/target_getTargets

Conversation

@cola119
Copy link
Copy Markdown
Member

@cola119 cola119 commented Mar 29, 2026 •
edited
Loading

Add Target.getTargets for worker inspection targets and move target state/session lookup logic out of TargetAgent into a dedicated TargetManager.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 29, 2026

Review requested:

  • @nodejs/gyp
  • @nodejs/inspector

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 29, 2026
@cola119 cola119 requested review from islandryu and legendecas March 29, 2026 02:26
@cola119 cola119 added inspector Issues and PRs related to the V8 inspector protocol request-ci Add this label to start a Jenkins CI on a PR. labels Mar 29, 2026
@cola119 cola119 force-pushed the feature/target_getTargets branch from 3a98316 to 6bc600c Compare March 29, 2026 02:31
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 29, 2026

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/23699703986

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 93.65079% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.70%. Comparing base (cc96741) to head (6bc600c).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/inspector/target_manager.cc 88.57% 1 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62487      +/-   ##
==========================================
- Coverage   91.55%   89.70%   -1.85%     
==========================================
  Files         351      694     +343     
  Lines      147653   214035   +66382     
  Branches    23224    41055   +17831     
==========================================
+ Hits       135179   192004   +56825     
- Misses      12217    14093    +1876     
- Partials      257     7938    +7681
Files with missing lines Coverage Δ
src/inspector/target_agent.cc 96.29% <100.00%> (ø)
src/inspector/target_agent.h 100.00% <100.00%> (ø)
src/inspector/target_manager.h 100.00% <100.00%> (ø)
src/inspector_io.cc 91.80% <100.00%> (ø)
src/inspector/target_manager.cc 88.57% <88.57%> (ø)

... and 458 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@islandryu islandryu added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Mar 29, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 29, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 29, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72187/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 30, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72265/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 30, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 31, 2026
@nodejs-github-bot nodejs-github-bot merged commit bf452bb into nodejs:main Mar 31, 2026
70 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Mar 31, 2026

Landed in bf452bb

aduh95 pushed a commit that referenced this pull request Mar 31, 2026
@cola119 @aduh95
inspector: add Target.getTargets and extract TargetManager
da5db26 
PR-URL: #62487
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Mar 31, 2026
@cola119 @aduh95
inspector: add Target.getTargets and extract TargetManager
b67a8fb 
PR-URL: #62487
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions github-actions bot mentioned this pull request Mar 31, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

@islandryu islandryu islandryu approved these changes

@legendecas legendecas Awaiting requested review from legendecas

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cola119 @nodejs-github-bot @aduh95 @islandryu