tools: fix --shared-ffi compilation on macOS#62737
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 14, 2026
Merged
tools: fix --shared-ffi compilation on macOS#62737nodejs-github-bot merged 1 commit intonodejs:mainfrom
--shared-ffi compilation on macOS#62737nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
panva
approved these changes
Apr 14, 2026
RafaelGSS
approved these changes
Apr 14, 2026
ShogunPanda
approved these changes
Apr 14, 2026
Contributor
|
Fast-track has been requested by @aduh95. Please π to approve. |
atlowChemi
approved these changes
Apr 14, 2026
Contributor
Author
|
CQ is still blocked by nodejs/node-core-utils#1059 |
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62737
β Done loading data for nodejs/node/pull/62737
----------------------------------- PR info ------------------------------------
Title tools: fix `--shared-ffi` compilation on macOS (#62737)
β Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch aduh95:fix-shared-ffi -> nodejs:main
Labels tools, fast-track, author ready
Commits 1
- tools: fix `--shared-ffi` compilation on macOS
Committers 1
- Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62737
Refs: https://github.com/NixOS/nixpkgs/blob/13043924aaa7375ce482ebe2494338e058282925/pkgs/top-level/all-packages.nix#L6695-L6698
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62737
Refs: https://github.com/NixOS/nixpkgs/blob/13043924aaa7375ce482ebe2494338e058282925/pkgs/top-level/all-packages.nix#L6695-L6698
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
--------------------------------------------------------------------------------
βΉ This PR was created on Tue, 14 Apr 2026 14:28:50 GMT
β Approvals: 4
β - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/62737#pullrequestreview-4106737238
β - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/62737#pullrequestreview-4106765490
β - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/62737#pullrequestreview-4106767822
β - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/62737#pullrequestreview-4107107923
βΉ This PR is being fast-tracked
β Last GitHub CI successful
βΉ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
β No git cherry-pick in progress
β No git am in progress
β No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
β origin/main is now up-to-date
- Downloading patch for 62737
From https://github.com/nodejs/node
* branch refs/pull/62737/merge -> FETCH_HEAD
β Fetched commits as d0fa608c0796..dd0e66fdfd90
--------------------------------------------------------------------------------
[main be80ce7283] tools: fix `--shared-ffi` compilation on macOS
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Tue Apr 14 16:26:44 2026 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
β Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
PR-URL: https://github.com/nodejs/node/pull/62737
Refs: https://github.com/NixOS/nixpkgs/blob/13043924aaa7375ce482ebe2494338e058282925/pkgs/top-level/all-packages.nix#L6695-L6698
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
--------------------------------------------------------------------------------
[main 6061758826] PR-URL: https://github.com/nodejs/node/pull/62737 Refs: https://github.com/NixOS/nixpkgs/blob/13043924aaa7375ce482ebe2494338e058282925/pkgs/top-level/all-packages.nix#L6695-L6698 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Tue Apr 14 16:26:44 2026 +0200
1 file changed, 1 insertion(+), 1 deletion(-)
β 60617588265df1bc1e0de9e97e4ea642ddf07a1e
β 0:0 no Co-authored-by metadata co-authored-by-is-trailer
β 0:0 skipping fixes-url fixes-url
β 1:0 blank line expected after title line-after-title
β 0:0 line-lengths are valid line-length
β 0:0 metadata is at end of message metadata-end
β 0:0 Commit must have a PR-URL. pr-url
β 0:0 reviewers are valid reviewers
β 0:0 Invalid subsystem: "PR-URL" subsystem
β 0:0 Title is formatted correctly. title-format
β 0:0 Title is <= 50 columns. title-length
βΉ Please fix the commit message and try again.
Please manually ammend the commit message, by running
`git commit --amend`
Once commit message is fixed, finish the landing command running
`git node land --continue`https://github.com/nodejs/node/actions/runs/24407872429 |
Collaborator
|
Landed in a0160a8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/NixOS/nixpkgs/blob/13043924aaa7375ce482ebe2494338e058282925/pkgs/top-level/all-packages.nix#L6695-L6698
Refs: #62731 (comment)
The CI didn't catch it because we're explicitely disabling FFI support on macOS test-shared.