Skip to content

src: replace snapshot flag with affects_annotation#62930

Open
watilde wants to merge 2 commits intonodejs:mainfrom
watilde:snapshot-todo
Open

src: replace snapshot flag with affects_annotation#62930
watilde wants to merge 2 commits intonodejs:mainfrom
watilde:snapshot-todo

Conversation

@watilde
Copy link
Copy Markdown
Member

@watilde watilde commented Apr 24, 2026

No description provided.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

Comment thread src/node_snapshotable.cc
@watilde watilde changed the title lib: detect --frozen-intrinsics mismatch when loading src: replace snapshot flag with affects_annotation Apr 25, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2026

Codecov Report

❌ Patch coverage is 55.55556% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.64%. Comparing base (2428030) to head (2dc4329).
⚠️ Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
src/node_options.cc 40.54% 21 Missing and 1 partial ⚠️
src/node_snapshotable.cc 58.82% 18 Missing and 3 partials ⚠️
src/node_options.h 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #62930    +/-   ##
========================================
  Coverage   89.63%   89.64%            
========================================
  Files         706      706            
  Lines      219219   219468   +249     
  Branches    42004    42074    +70     
========================================
+ Hits       196499   196740   +241     
+ Misses      14622    14621     -1     
- Partials     8098     8107     +9     
Files with missing lines Coverage Δ
src/node.h 92.30% <ø> (ø)
src/node_options-inl.h 83.39% <100.00%> (-0.31%) ⬇️
src/node_options.h 97.57% <85.71%> (-0.42%) ⬇️
src/node_snapshotable.cc 68.70% <58.82%> (-0.81%) ⬇️
src/node_options.cc 75.28% <40.54%> (-1.33%) ⬇️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants