Skip to content

lib: add Temporal to frozen intrinsics#63029

Open
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Renegade334:freeze-temporal-intrinsics
Open

lib: add Temporal to frozen intrinsics#63029
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Renegade334:freeze-temporal-intrinsics

Conversation

@Renegade334
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
@Renegade334 Renegade334 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Apr 29, 2026
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.64%. Comparing base (8173251) to head (66cce03).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63029      +/-   ##
==========================================
- Coverage   91.49%   89.64%   -1.85%     
==========================================
  Files         358      708     +350     
  Lines      151574   220389   +68815     
  Branches    23921    42263   +18342     
==========================================
+ Hits       138679   197570   +58891     
- Misses      12619    14655    +2036     
- Partials      276     8164    +7888     
Files with missing lines Coverage Δ
lib/internal/freeze_intrinsics.js 96.97% <100.00%> (+0.08%) ⬆️

... and 471 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread lib/internal/freeze_intrinsics.js
@Renegade334 Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may also want to include Temporal.Now

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@Renegade334
Copy link
Copy Markdown
Member Author

you may also want to include Temporal.Now

It's recursively covered by deepFreeze().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants