test_runner: fix failing suite hooks when marked with todo#63097
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 5, 2026
Merged
test_runner: fix failing suite hooks when marked with todo#63097nodejs-github-bot merged 1 commit intonodejs:mainfrom
todo#63097nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
atlowChemi
approved these changes
May 3, 2026
Collaborator
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63097 +/- ##
==========================================
+ Coverage 89.65% 89.66% +0.01%
==========================================
Files 712 712
Lines 220512 220512
Branches 42289 42287 -2
==========================================
+ Hits 197690 197717 +27
+ Misses 14663 14656 -7
+ Partials 8159 8139 -20
🚀 New features to boost your workflow:
|
MoLow
added
author ready
benjamingr
approved these changes
May 3, 2026
avivkeller
approved these changes
May 3, 2026
JakobJingleheimer
approved these changes
May 3, 2026
UlisesGascon
approved these changes
May 4, 2026
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 480ee08 |
aduh95
pushed a commit
that referenced
this pull request
May 5, 2026
Signed-off-by: Moshe Atlow <moshe@atlow.co.il> PR-URL: #63097 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.