test: move FFI tests to NATIVE_SUITES#63165
Merged
Merged
Conversation
nodejs-github-bot
added
build
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63165 +/- ##
========================================
Coverage 90.03% 90.04%
========================================
Files 713 713
Lines 224510 224926 +416
Branches 42438 42526 +88
========================================
+ Hits 202148 202527 +379
- Misses 14163 14177 +14
- Partials 8199 8222 +23 🚀 New features to boost your workflow:
|
richardlau
reviewed
May 7, 2026
| # This target should not use a native compiler at all | ||
| # Related CI job: node-test-commit-arm-fanned | ||
| test-ci-js: | clear-stalled ## Build and test JavaScript with building anything else. | ||
| test-ci-js: | clear-stalled build-ffi-tests ## Build and test JavaScript with building anything else. |
Member
There was a problem hiding this comment.
This is a fly by comment as I'm not at a computer at the moment to investigate in detail, but this does not feel correct. By definition test-ci-js should not require a native compiler -- those tests should be in test-ci-native. I can see a few lines above have test/ffi/.buildstamp as a requisite for test-ci-native, so my assumption would be that the ffi testsuite has been misclassified into CI_JS_SUITES instead of CI_NATIVE_SUITES.
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
changed the title
build-ffi-tests as a requesite of test-ci-jsNATIVE_SUITES
richardlau
approved these changes
May 11, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
richardlau
added
the
author ready
lpinca
approved these changes
May 14, 2026
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f56c4c5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without it, I'm getting
Missing FFI test fixture librarywhen runningtest-js-cion 26.1.0