Skip to content

doc: fix promise nomenclature in stream_iter.md#63406

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:stream-iter-promise
Open

doc: fix promise nomenclature in stream_iter.md#63406
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:stream-iter-promise

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented May 18, 2026

According to https://tc39.es/ecma262/#sec-promise-objects:

An unresolved promise is always in the pending state. A resolved promise may be pending, fulfilled or rejected.

Using "resolve" is ambiguous and is not what we actually mean in most cases.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 18, 2026
@Renegade334
Copy link
Copy Markdown
Member

The fs.md stream/iter methods are also using the unsupported T<...> syntax: https://github.com/search?q=repo%3Anodejs%2Fnode+path%3A%2F%5Edoc%5C%2Fapi%5C%2F%2F+%2F%5C%7B%5B%5E%7D%5Cs%5D%2B%3C%2F&type=code

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants