doc: explicitly ask for reproducible in JS#63479
Merged
nodejs-github-bot merged 1 commit intoMay 26, 2026
Merged
Conversation
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Collaborator
|
Review requested:
|
marco-ippolito
approved these changes
May 21, 2026
richardlau
reviewed
May 21, 2026
aduh95
reviewed
May 21, 2026
aduh95
approved these changes
May 21, 2026
richardlau
approved these changes
May 21, 2026
aduh95
reviewed
May 21, 2026
| 4. **Report Quality** | ||
| * Provide clear, detailed steps to reproduce the vulnerability. | ||
| * Include only the minimum proof of concept required to demonstrate the issue. | ||
| * Include only the minimum proof of concept required to demonstrate the issue, written in JavaScript/TypeScript. |
Member
There was a problem hiding this comment.
I think the point is not about the language but rather that the repor can be run by Node.js alone without external tools/languages
Member
Author
There was a problem hiding this comment.
Sorry, I don't understand. That's about the language, including your statement, which mentions that:
without external languages
Member
There was a problem hiding this comment.
Well if its runnable by Node.js its either js or ts 😄
anonrig
approved these changes
May 21, 2026
UlisesGascon
approved these changes
May 21, 2026
mcollina
requested changes
May 23, 2026
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
github is showing me a full diff instead of just the line change
RafaelGSS
force-pushed
the
explicitly-ask-reproducible-js
branch
from
88f3ef3 to
2ed149b
Compare
Member
Author
just rebased and it seems to solve it |
jasnell
approved these changes
May 25, 2026
Member
Author
|
ptal @mcollina |
RafaelGSS
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63479 ✔ Done loading data for nodejs/node/pull/63479 ----------------------------------- PR info ------------------------------------ Title doc: explicitly ask for reproducible in JS (#63479) Author Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS) Branch RafaelGSS:explicitly-ask-reproducible-js -> nodejs:main Labels doc, author ready Commits 1 - doc: explicitly ask for reproducible in JS Committers 1 - RafaelGSS <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs/node/pull/63479 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63479 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 21 May 2026 15:47:14 GMT ✔ Approvals: 7 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/63479#pullrequestreview-4338459872 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/63479#pullrequestreview-4338496113 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/63479#pullrequestreview-4338514650 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/63479#pullrequestreview-4338866406 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/63479#pullrequestreview-4338927767 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/63479#pullrequestreview-4363409432 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/63479#pullrequestreview-4357567531 ✘ 3 GitHub CI job(s) cancelled: ✘ - lint-js-and-md: CANCELLED (https://github.com/nodejs/node/actions/runs/26236819950/job/77212188500) ✘ - test-linux (ubuntu-24.04-arm): CANCELLED (https://github.com/nodejs/node/actions/runs/26236820009/job/77212188382) ✘ - test-linux (ubuntu-24.04): CANCELLED (https://github.com/nodejs/node/actions/runs/26236820009/job/77212188383) ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/26451423810 |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in cd58afc |
aduh95
pushed a commit
that referenced
this pull request
May 27, 2026
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #63479 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled