inspector: capture HTTP body before decoding#64496
Open
Archkon wants to merge 2 commits into
Open
Conversation
Capture HTTP response body chunks before stream decoding so network inspection receives the original bytes when user code calls response.setEncoding(). Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
Contributor
Author
|
@legendecas Could you review this pr and I don't completely know the context for the commit a78f7d9 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64496 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 741 741
Lines 241688 241695 +7
Branches 45550 45550
=======================================
+ Hits 218084 218097 +13
+ Misses 15157 15151 -6
Partials 8447 8447
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64494