sqlite: check database state before calling SQLite - #64812
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64812 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.01%
==========================================
Files 746 746
Lines 242660 242821 +161
Branches 45716 45765 +49
==========================================
+ Hits 218763 218896 +133
- Misses 15399 15419 +20
- Partials 8498 8506 +8
🚀 New features to boost your workflow:
|
Renegade334
reviewed
Jul 29, 2026
geeksilva97
approved these changes
Jul 29, 2026
geeksilva97
added
request-ci
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Check whether the database is open in enableLoadExtension() and setAuthorizer() before passing the connection to SQLite. This prevents calls after close() from terminating the process and makes them throw ERR_INVALID_STATE instead. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: codex:gpt-5.6-sol
trivikr
force-pushed
the
sqlite-crash-api-after-close
branch
from
July 29, 2026 13:57
bff0854 to
76df88c
Compare
Renegade334
approved these changes
Jul 29, 2026
trivikr
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64811
This change checks that the database is open before calling the corresponding
SQLite APIs. Both methods now throw
ERR_INVALID_STATE, consistent with otherDatabaseSyncmethods.Assisted-by: codex:gpt-5.6-sol