dns: validate port range in setServers() - #65021
Open
Renegade334 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
Collaborator
|
Review requested:
|
avivkeller
approved these changes
Aug 4, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65021 +/- ##
==========================================
- Coverage 90.30% 90.30% -0.01%
==========================================
Files 759 759
Lines 247634 247636 +2
Branches 46684 46697 +13
==========================================
- Hits 223630 223629 -1
- Misses 15467 15468 +1
- Partials 8537 8539 +2
🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #65009 (review).
dns.setServers()currently has the following shenanigans with out-of-range port numbers:(the latter of these is not addressed by #65009)