Skip to content

quic: mark drain promise handled - #65319

Open
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/mark-drain-promise-handled
Open

quic: mark drain promise handled#65319
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/mark-drain-promise-handled

Conversation

@jasnell

@jasnell jasnell commented Aug 16, 2026

Copy link
Copy Markdown
Member

Fixes: #64290

@nodejs/quic @martenrichter

Fixes: nodejs#64290
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode/Opus
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Aug 16, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented Aug 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.11%. Comparing base (86c871e) to head (39fa1e0).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65319      +/-   ##
==========================================
- Coverage   90.12%   90.11%   -0.01%     
==========================================
  Files         752      752              
  Lines      251569   251571       +2     
  Branches    47267    47267              
==========================================
- Hits       226738   226715      -23     
- Misses      16184    16201      +17     
- Partials     8647     8655       +8     
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martenrichter

Copy link
Copy Markdown
Contributor

lgtm Thanks!

@jasnell
jasnell requested review from Qard and pimterry August 16, 2026 13:50
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quic: QuicStream writer creates unhandled error

4 participants