Skip to content

Update how-to-prompt-for-command-line-input#2051

Merged
4 commits merged intonodejs:masterfrom
Yash-Handa:promp-cmd
Feb 12, 2019
Merged

Update how-to-prompt-for-command-line-input#2051
4 commits merged intonodejs:masterfrom
Yash-Handa:promp-cmd

Conversation

@Yash-Handa
Copy link
Copy Markdown
Contributor

@Yash-Handa Yash-Handa commented Feb 8, 2019

Hey @chowdhurian and @fhemberger,
In accordance with issue #1977, I have updated the Article how-to-prompt-for-command-line-input with the following changes:

  • Exchanged direct stdin usage with readline module
  • Added example of readline module.
  • some other miscellaneous updates and refactors.

If there are any suggestion/enhancement/tips please feel free to tell me, I would love to incorporate those changes in this Article 😄

NOTE: This article explains prompt package usage, which hasn't been updated in 2yrs. Please let me know if some other package should be used instead of this like (inquirer, prompts, etc)

Updated the first half of the article.
Updated prompt github repo link
@Yash-Handa Yash-Handa changed the title Promp cmd Update how-to-prompt-for-command-line-input Feb 8, 2019
Comment thread locale/en/knowledge/command-line/how-to-prompt-for-command-line-input.md Outdated
Comment thread locale/en/knowledge/command-line/how-to-prompt-for-command-line-input.md Outdated
@ghost
Copy link
Copy Markdown

ghost commented Feb 11, 2019

@Yash-Handa:LGTM!there're some nits in my comments, if possible you can fix or feedback to me :)

@Yash-Handa
Copy link
Copy Markdown
Contributor Author

Thanks, @Maledong for such precise and detailed comments 😄 (fixed those)

Thanks, @fhemberger for updating the Articles with ```js and ```bash will use this syntax in future Articles 😄

@ghost ghost merged commit dc47fa1 into nodejs:master Feb 12, 2019
@ghost
Copy link
Copy Markdown

ghost commented Feb 12, 2019

@Yash-Handa:Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants