Skip to content

chore: Use ES6 to write functions#2185

Merged
1 commit merged intomasterfrom
unknown repository
Apr 17, 2019
Merged

chore: Use ES6 to write functions#2185
1 commit merged intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 13, 2019

The 'json.js' file isn't referred, so remove it.

Use ES6 to write functions for 'm.read' and 'Object.keys.forEach' in 'build.js'.

Copy link
Copy Markdown
Member

@ZYSzys ZYSzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure exactly, maybe it's used to replace this
bee3f0d#diff-efd59cd1bdc5c9ac6d0eaa368f1e149fL164 ?

@fhemberger
Copy link
Copy Markdown
Contributor

@ZYSzys Yes, you're right. But I can't remember where we needed the json Markdown helper in the first place … 🤔

@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 16, 2019

So this file shouldn't be removed? Well……I didn't find anywhere to refer…… XD

@richardlau
Copy link
Copy Markdown
Member

So this file shouldn't be removed? Well……I didn't find anywhere to refer…… XD

It's indirectly referenced:

nodejs.org/build.js

Lines 158 to 161 in 2ca6dec

.use(discoverHelpers({
directory: 'scripts/helpers',
pattern: /\.js$/
}))

Use ES6 to write `m.read` and `Object.keys...` functions.
@ghost ghost changed the title chore: Remove 'scripts/helpers/json.js' chore: Use ES6 to write functions Apr 16, 2019
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 16, 2019

Thanks all! I've changed the topic to another submit :)

@ghost ghost requested a review from ZYSzys April 16, 2019 07:38
@ghost ghost merged commit 3e3b547 into nodejs:master Apr 17, 2019
@ghost ghost deleted the RemoveFile branch April 17, 2019 01:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants