Make Node.js 8.x the minimum version.#2421
Merged
2 commits merged intonodejs:masterfrom Aug 17, 2019
XhmikosR:xmr-node-ver
Merged
Make Node.js 8.x the minimum version.#24212 commits merged intonodejs:masterfrom XhmikosR:xmr-node-ver
2 commits merged intonodejs:masterfrom
XhmikosR:xmr-node-ver
Conversation
Trott
reviewed
Aug 17, 2019
| This will start the development server on http://localhost:8080/en/. This should reload automatically when you make changes to the code, but no code is perfect, so sometimes you may need to restart it. :) | ||
|
|
||
| Note: You'll need Node.js v4 or newer as the build system uses some native ES2015 features. | ||
| Note: You'll need Node.js 8.x or newer as the build system uses some native ES2015 features. |
Member
There was a problem hiding this comment.
We could probably just remove that line entirely?
Contributor
Author
There was a problem hiding this comment.
Agreed. I just went with the minimum changes :P
Trott
approved these changes
Aug 17, 2019
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.