doc: remove BLM TODO#3402
Merged
MylesBorins merged 1 commit intonodejs:masterfrom Sep 27, 2020
MylesBorins:fix-todo
Merged
Conversation
When I originally reviewed the PR for upgrading styles I did not notice this additional TODO which makes a time commitment for removing the BLM banner. This is not something I would have signed off on and as such I think we should revert this line. Refs: d29ad75#diff-0eb67dac6cfdc75724b04f6a2c4eaf5d
Trott
approved these changes
Sep 26, 2020
Member
|
I assume the comment was added in good faith and was merely intended as a reminder that when the BLM call-to-action is removed, the styling can also be removed. But yeah, if it's being treated as an indicator of any kind of decision on that, let's remove the comment. |
DerekNonGeneric
approved these changes
Sep 26, 2020
apapirovski
approved these changes
Sep 26, 2020
Contributor
Yep, that's why I put it there. |
bnb
approved these changes
Sep 26, 2020
mmarchini
approved these changes
Sep 26, 2020
joesepi
approved these changes
Sep 26, 2020
gireeshpunathil
approved these changes
Sep 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I originally reviewed the PR for upgrading styles I did not
notice this additional TODO which makes a time commitment
for removing the BLM banner.
This is not something I would have signed off on and as such
I think we should revert this line.
Refs: d29ad75#diff-0eb67dac6cfdc75724b04f6a2c4eaf5d